Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msrv patch for tokio-stream, and other lint changes #2086

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Sep 9, 2024

Changes

Error: https://github.com/open-telemetry/opentelemetry-rust/actions/runs/10751933526/job/29819701086?pr=2083

  Downloaded linux-raw-sys v0.4.14
error: package `tokio-stream v0.1.16` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.65.0
Either upgrade to rustc 1.70 or newer, or use
cargo update -p [email protected] --precise ver
where `ver` is the latest version of `tokio-stream` supporting rustc 1.65.0
Error: Process completed with exit code 101.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (a50e3ff) to head (b1858d6).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2086   +/-   ##
=====================================
  Coverage   77.8%   77.9%           
=====================================
  Files        121     121           
  Lines      20970   20969    -1     
=====================================
  Hits       16335   16335           
+ Misses      4635    4634    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb mentioned this pull request Sep 9, 2024
4 tasks
@lalitb
Copy link
Member Author

lalitb commented Sep 9, 2024

Waiting for #2083 to be incorporated with these changes, as both should go together,

@lalitb lalitb marked this pull request as ready for review September 9, 2024 17:46
@lalitb lalitb requested a review from a team September 9, 2024 17:46
@lalitb lalitb changed the title msrv patch for tokio-stream msrv patch for tokio-stream, and other lint changes Sep 9, 2024
@cijothomas cijothomas merged commit 6c4f50e into open-telemetry:main Sep 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants