Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Correlation Context into Baggage #208

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Rename Correlation Context into Baggage #208

merged 2 commits into from
Sep 3, 2020

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Sep 3, 2020

Fix #196
This PR:

  • Rename CorrelationContextPropagator into BaggagePropagator
  • Rename CorrelationContextExt into BaggageExt
  • Delete Correlations since it seems OK to use Baggage/CorrlectionContext directly.

@TommyCpp
Rename Correlation Context into Baggage.
b973437 
* Rename CorrelationContextPropagator into BaggagePropagator.
* Rename Correlations into BaggageWrapper.
@TommyCpp
Remove BaggageWrapper.
9c58d74 
There seems no reason why we need BaggageWrapper/Correlations.
@TommyCpp TommyCpp requested a review from a team September 3, 2020 00:42
jtescher
jtescher approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @TommyCpp

@jtescher jtescher merged commit dc6fd88 into open-telemetry:master Sep 3, 2020
@TommyCpp TommyCpp deleted the baggage branch September 23, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename CorrelationContext to Baggage
2 participants
@TommyCpp @jtescher