Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more stable metrics sdk tests #1768

Merged

Conversation

cijothomas
Copy link
Member

Follow up to #1766, we can make tests more predictable!

@cijothomas cijothomas requested a review from a team May 15, 2024 00:54
@cijothomas cijothomas changed the title Cijothomas/metric test fix2 more stable metrics sdk tests May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.6%. Comparing base (348ec9e) to head (5b2b5bd).
Report is 36 commits behind head on main.

Files Patch % Lines
opentelemetry-sdk/src/metrics/mod.rs 85.7% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1768     +/-   ##
=======================================
+ Coverage   71.0%   71.6%   +0.6%     
=======================================
  Files        135     136      +1     
  Lines      20751   20857    +106     
=======================================
+ Hits       14746   14951    +205     
+ Misses      6005    5906     -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 1733da5 into open-telemetry:main May 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants