Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global shutdown from metrics and doc fixes #1743

Merged

Conversation

cijothomas
Copy link
Member

Fixes #1679

@cijothomas cijothomas requested a review from a team May 11, 2024 21:14
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.6%. Comparing base (348ec9e) to head (fe4dd4c).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1743     +/-   ##
=======================================
+ Coverage   71.0%   71.6%   +0.5%     
=======================================
  Files        135     136      +1     
  Lines      20751   20829     +78     
=======================================
+ Hits       14746   14924    +178     
+ Misses      6005    5905    -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member

lalitb commented May 11, 2024

Just to summarise my understanding of the existing behavior after this PR:

  • The global shutdown is now removed for metrics and logs. And shutdown will happen when
    • explicitly invoked from any of the Sdk*Provider's, Or
    • All the references to the providers are dropped.
  • From traces, global shutdown will drop the global provider, and invoke shutdown (through drop) if there are no other provider references.

@cijothomas cijothomas merged commit 78c5c08 into open-telemetry:main May 13, 2024
20 checks passed
@cijothomas cijothomas deleted the cijothomas/metric-shutdown-remove branch May 13, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit shutdown_signal_provider methods at API level
3 participants