Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1611

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Fix CI #1611

merged 6 commits into from
Mar 11, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Mar 11, 2024

Changes

#1607 merge somehow triggered CI error as mentioned here - #1607 (comment). I don't fully understand the msrv CI test, it seems to be executing scripts/patch_dependencies.sh, but the function patch_version from this script is never called anywhere.
However, downgrading to criterion 0.3 seems to be fixing the error.

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team March 11, 2024 18:34
@lalitb lalitb marked this pull request as draft March 11, 2024 18:41
@lalitb
Copy link
Member Author

lalitb commented Mar 11, 2024

markdown-link-check is failing for a bug in its new release- tcort/markdown-link-check#304. Waiting for the newer version to be released with fix.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.0%. Comparing base (e816cb9) to head (6b3d144).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1611   +/-   ##
=====================================
  Coverage   67.0%   67.0%           
=====================================
  Files        138     138           
  Lines      19515   19515           
=====================================
  Hits       13084   13084           
  Misses      6431    6431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb marked this pull request as ready for review March 11, 2024 20:49
@lalitb lalitb changed the title Fix CI and benchmark Fix CI Mar 11, 2024
@cijothomas cijothomas merged commit 440725e into open-telemetry:main Mar 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants