-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add error logging for failed OpenTelemetry HTTP export #1498
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
=======================================
- Coverage 63.7% 63.6% -0.1%
=======================================
Files 144 144
Lines 19983 20005 +22
=======================================
Hits 12741 12741
- Misses 7242 7264 +22 ☔ View full report in Codecov by Sentry. |
@mustakimali It seems the OTLP HTTP export for logs also suffer from this issue, would you be able to replicate these changes for logs too -
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these!
I spent quite some time trying to get the exporter to send traces to Honeycomb.
The only error I could see wasn't entirely useful.
I had to
To see the actual reason my traces were not being published. So it should be useful for others too.
Changes
The HTTP exporter prints the endpoint URL and the raw response from the telemetry provider if the request fails.
Before
After
ℹ️ The Url requires allocation, so the log won't be emitted in release mode. The log is mostly useful when setting up tracing locally.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes