Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid View to proceed as if view did not exist #1408

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

cijothomas
Copy link
Member

Trying to see if my interpretation of this part of the spec is correct. In case of a view config that has invalid stream configuration, should we proceed as if the view did not exist completely? Or should we ignore the specific part of view that was invalid, and proceed with rest of the view config?

For this specific case, I simulated invalid stream config by providing invalid bounds. Should we ignore the bounds and fallback to default bounds? OR should we ignore the whole view config itself?

@cijothomas cijothomas requested a review from a team November 28, 2023 03:32
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fcd12eb) 57.3% compared to head (ac1aca3) 57.6%.

Files Patch % Lines
opentelemetry-sdk/src/metrics/mod.rs 95.5% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1408     +/-   ##
=======================================
+ Coverage   57.3%   57.6%   +0.3%     
=======================================
  Files        146     146             
  Lines      18179   18224     +45     
=======================================
+ Hits       10422   10504     +82     
+ Misses      7757    7720     -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 772f75a into open-telemetry:main Nov 30, 2023
14 checks passed
@cijothomas cijothomas deleted the cijothomas/view_bug1 branch November 30, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants