Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric SDK - remove de-duplicating attributes for perf gain #1398

Merge branch 'main' into cijothomas/metric-dedup-removal

17ff310
Select commit
Loading
Failed to load commit list.
Closed

Metric SDK - remove de-duplicating attributes for perf gain #1398

Merge branch 'main' into cijothomas/metric-dedup-removal
17ff310
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 27, 2023 in 1s

57.6% (+0.2%) compared to fcd12eb

View this Pull Request on Codecov

57.6% (+0.2%) compared to fcd12eb

Details

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fcd12eb) 57.3% compared to head (17ff310) 57.6%.

Files Patch % Lines
opentelemetry-sdk/src/metrics/mod.rs 96.9% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1398     +/-   ##
=======================================
+ Coverage   57.3%   57.6%   +0.2%     
=======================================
  Files        146     146             
  Lines      18179   18239     +60     
=======================================
+ Hits       10422   10508     +86     
+ Misses      7757    7731     -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.