Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jaeger tracing example to main examples #1345

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Nov 7, 2023

As discussed in #1323 (comment), trying to start with a working example for using OTLP to export to jaeger.

We had added an example previously in #1022, but it got lost in refactoring. This PR is adding a top-level example using Jaeger with OTLP Exporter.

Good examples are a pre-req for achieving #995

@cijothomas cijothomas marked this pull request as ready for review November 7, 2023 01:09
@cijothomas cijothomas requested a review from a team November 7, 2023 01:09
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jtescher jtescher merged commit 6c3dc78 into open-telemetry:main Nov 7, 2023
14 checks passed
@cijothomas cijothomas deleted the cijothomas/jaeger-example branch November 7, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants