Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attach method to Contextualized #1277

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Add attach method to Contextualized #1277

merged 1 commit into from
Sep 25, 2023

Conversation

shaun-cox
Copy link
Contributor

@shaun-cox shaun-cox commented Sep 21, 2023 •
edited
Loading

Changes

Adds a convenience method to Contextualized which consumes self and returns both the inner T along with an Option<ContextGuard> after attaching the inner optional Context.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes

@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Patch coverage is 100.0% of modified lines.

Files Changed Coverage
opentelemetry-contrib/src/trace/context.rs 100.0%

📢 Thoughts on this report? Let us know!.

@shaun-cox shaun-cox changed the title Add attach_context method to Contextualized Add attach method to Contextualized Sep 22, 2023
@shaun-cox shaun-cox marked this pull request as ready for review September 22, 2023 19:55
@shaun-cox shaun-cox requested a review from a team September 22, 2023 19:55
@jtescher jtescher merged commit 08c3d48 into open-telemetry:main Sep 25, 2023
12 checks passed
@shaun-cox shaun-cox deleted the contexualized branch September 25, 2023 17:06
@lalitb lalitb mentioned this pull request Nov 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc left review comments

@TommyCpp TommyCpp TommyCpp approved these changes

@lalitb lalitb lalitb approved these changes

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shaun-cox @djc @jtescher @lalitb @TommyCpp