Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Nil value for db.name attribute #744

Merged
merged 1 commit into from
May 7, 2021
Merged

Fix: Nil value for db.name attribute #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions instrumentation/mysql2/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,22 @@
# Release History: opentelemetry-instrumentation-mysql2

### Unreleased

* Fix: Nil value for db.name attribute #744

### v0.17.0 / 2021-04-22

* (No significant changes)

### v0.16.0 / 2021-03-17

* FIXED: Update DB semantic conventions
* FIXED: Example scripts now reference local common lib
* FIXED: Update DB semantic conventions
* FIXED: Example scripts now reference local common lib
* ADDED: Configurable obfuscation of sql in mysql2 instrumentation to avoid logging sensitive data

### v0.15.0 / 2021-02-18

* ADDED: Add instrumentation config validation
* ADDED: Add instrumentation config validation

### v0.14.0 / 2021-02-03

Expand All @@ -28,32 +32,32 @@

### v0.11.0 / 2020-12-11

* ADDED: Add peer service config to mysql
* FIXED: Copyright comments to not reference year
* ADDED: Add peer service config to mysql
* FIXED: Copyright comments to not reference year

### v0.10.1 / 2020-12-09

* FIXED: Semantic conventions db.type -> db.system
* FIXED: Semantic conventions db.type -> db.system

### v0.10.0 / 2020-12-03

* (No significant changes)

### v0.9.0 / 2020-11-27

* BREAKING CHANGE: Add timeout for force_flush and shutdown
* BREAKING CHANGE: Add timeout for force_flush and shutdown

* ADDED: Add timeout for force_flush and shutdown
* ADDED: Add timeout for force_flush and shutdown

### v0.8.0 / 2020-10-27

* BREAKING CHANGE: Remove 'canonical' from status codes
* BREAKING CHANGE: Remove 'canonical' from status codes

* FIXED: Remove 'canonical' from status codes
* FIXED: Remove 'canonical' from status codes

### v0.7.0 / 2020-10-07

* DOCS: Standardize toplevel docs structure and readme
* DOCS: Standardize toplevel docs structure and readme

### v0.6.0 / 2020-09-10

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/mysql2/lib/opentelemetry/instrumentation/mysql2/patches/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@ def client_attributes

attributes = {
'db.system' => 'mysql',
'db.name' => database_name,
'net.peer.name' => host,
'net.peer.port' => port
}
attributes['db.name'] = database_name if database_name
attributes['peer.service'] = config[:peer_service] if config[:peer_service]
attributes
end
Expand Down