Add documentation on usage scenarios for span processors #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelleahklein
requested review from
dazuma,
ericmustin,
fbogsany,
mwear and
robertlaurin
as code owners
fbogsany
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #397. As noted in that issue, there wasn't anything in the spec about the different scenarios in which to use simple vs. batch span processors, so I ended up making a spec PR for this as well: open-telemetry/opentelemetry-specification#1135.
As of this writing, my spec PR has received one approval and there are no open questions or requested changes related to the differences between the two types of span processors. The documentation I'm submitting here is extracted from that PR.