Refactor approvers #334
Merged
Refactor approvers #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbogsany
requested review from
bai,
dazuma,
elskwid,
luvtechno and
mwear
as code owners
mwear
approved these changes
Aug 25, 2020
|
I’ll keep this open for 48 hours, in case anyone wants to voice concerns or objections. |
bai
approved these changes
Aug 25, 2020
|
I've updated this to add @ericmustin as an Approver as well, after discussion with @mwear. This is blocked on open-telemetry/community#460. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds @robertlaurin to the list of Approvers for OpenTelemetry Ruby. Robert contributed the Resource auto-detectors. He also maintains Shopify's wrapper gem for OpenTelemetry.
This also proposes removing @bai, @luvtechno and @elskwid from the Approvers list. They have not been active in this project for many months, at least. We're very grateful for @elskwid's early contributions, in particular, however Approver status requires continued active involvement in the project.