Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update references to logging exporter #1731

Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Sep 20, 2024

This exporter has been replaced by the debug exporter and will be removed soon

Related to open-telemetry/opentelemetry-collector#11037

This exporter has been replaced by the debug exporter and will be removed soon

Signed-off-by: Alex Boten <[email protected]>
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, @codeboten!

I think the metrics example updates are great. The otel-collector example updates don't work quite yet.

The version of the collector in examples/otel-collector/.env predates the debug exporter. It currently uses 0.35.0. However, when we update to the earliest version with the debug exporter, 0.86.0, we hit problems with the Jaeger exporter no longer being present in the collector.

I've tried a few things to fix this, including following the documentation to update Jaeger, but couldn't get it to work. It feels serendipitous that you're the author of that doc and of this PR.

I totally get it if this was just a quick PR and you don't have more time to spend on this problem. If you do have more time to spend, I would appreciate your help getting this example to work on a newer version of the collector.

Happy to send along more details on my exploits if you have the bandwidth!

@codeboten
Copy link
Contributor Author

@kaylareopelle i've updated the example to use v0.109.0 of the collector, take a look and see if it works on your end. I tested it locally and was able to see a trace in jaeger

Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @codeboten! This works for me too 😄

@mwear mwear merged commit b0ecc1c into open-telemetry:main Oct 1, 2024
62 checks passed
@codeboten codeboten deleted the codeboten/rm-logging-references branch October 1, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants