Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add log record processors #1682

Merged
merged 7 commits into from
Aug 23, 2024

Conversation

kaylareopelle
Copy link
Contributor

@kaylareopelle kaylareopelle commented Aug 14, 2024

This PR adds a Simple Log Record Processor and a Batching Log Record Processor.

Closes #1485
Closes #1486

(Failure is for an unrelated suite)

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be nice if we can extract the batching logic to be signal agnostic and make it shareable between spans and logs. At a glance, it looks like this should be possible, but something we can do as a future refactor, possibly after logs are stabilized and integrated into the main SDK.

@kaylareopelle
Copy link
Contributor Author

LGTM. It would be nice if we can extract the batching logic to be signal agnostic and make it shareable between spans and logs. At a glance, it looks like this should be possible, but something we can do as a future refactor, possibly after logs are stabilized and integrated into the main SDK.

@mwear, I agree! I created #1528 to track this a while back. Once we get logs to stability, I think there's a lot that could be shared between logs and traces.

@mwear mwear merged commit de318da into open-telemetry:main Aug 23, 2024
60 checks passed
@kaylareopelle kaylareopelle deleted the add-log-record-processors branch October 11, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs SDK - Batching LogRecordProcessor Logs SDK - Simple LogRecordProcessor
2 participants