Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initialize metrics exporter http gem #1670

Merged
merged 11 commits into from
Aug 23, 2024
Merged

feat: initialize metrics exporter http gem #1670

merged 11 commits into from
Aug 23, 2024

Conversation

xuan-cao-swi
Copy link
Contributor

Description

Follow-up PR for #1641.

  1. Added the Metrics module (nested under module OTLP) to avoid overriding OTLP Exporter version (OpenTelemetry::Exporter::OTLP::VERSION -> OpenTelemetry::Exporter::OTLP::Metrics::VERSION)

Updated script for testing

require 'opentelemetry/sdk'
require 'opentelemetry-metrics-sdk'
require 'opentelemetry-exporter-otlp-metrics'

OpenTelemetry::SDK.configure
console_metric_exporter = OpenTelemetry::Exporter::OTLP::Metrics::MetricsExporter.new # <- change
OpenTelemetry.meter_provider.add_metric_reader(console_metric_exporter)
meter = OpenTelemetry.meter_provider.meter("sample_ruby_meter_name")

meter.create_histogram(...)

xuan-cao-swi and others added 4 commits August 1, 2024 13:59
@xuan-cao-swi
remove version_rb_path for metrics exporter in release
ea43aa0
@xuan-cao-swi
lint
a18556f
@kaylareopelle
chore: Update metrics exporter README
74d3147 
This removes content related to installing the gem before the metrics
API and SDK gems were released.
@kaylareopelle
chore: Update MetricsExporter class in example
f64b41b 
Now, there's an extra Metrics:: namespace
kaylareopelle
kaylareopelle requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this! I noticed the README and example also needed some updates, so I opened xuan-cao-swi#4 with some changes there.

exporter/otlp-metrics/lib/opentelemetry/exporter/otlp/metrics/metrics_exporter.rb Outdated Show resolved Hide resolved
exporter/otlp-metrics/lib/opentelemetry/exporter/otlp/metrics/metrics_exporter.rb Outdated Show resolved Hide resolved
exporter/otlp-metrics/lib/opentelemetry/exporter/otlp/metrics/metrics_exporter.rb Show resolved Hide resolved
@kaylareopelle kaylareopelle mentioned this pull request Aug 9, 2024
Closed
@kaylareopelle kaylareopelle mentioned this pull request Aug 14, 2024
Closed
mwear
mwear approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We recently added mTLS support to the trace exporter (#1556). Can we make an issue to add this to the metrics exporter in the future?

@xuan-cao-swi xuan-cao-swi mentioned this pull request Aug 21, 2024
Closed
@xuan-cao-swi
Copy link
Contributor Author

@mwear
Created #1688

@mwear mwear merged commit 2f87a1d into open-telemetry:main Aug 23, 2024
60 checks passed
@xuan-cao-swi xuan-cao-swi deleted the initial-release-on-metrics-exporter branch August 26, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@mwear mwear mwear approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Assignees
No one assigned
Labels
metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuan-cao-swi @mwear @kaylareopelle