feat: Improve SSL error logging. #1557
Conversation
megabus-tobin
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam and
robbkidd
as code owners
exporter/otlp-http/lib/opentelemetry/exporter/otlp/http/trace_exporter.rb
Outdated
Show resolved
Hide resolved
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Log more information about why an SSL error occured as this can be very difficult to diagnose. This is logged in the same way as other probably fatal issues are, e.g. HTTP 404s.
megabus-tobin
force-pushed
the
ssl-error-logging
branch
from
6dab7f3 to
cf8c702
Compare
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
I missed that this had been closed automatically. It wold still be good to get this in if possible to make debugging SSL related errors easier. |
|
Hi @megabus-tobin , I missed that too. Thanks for bringing this to our attention. I'm not able to reopen the PR, the button is null with the message: |
|
@kaylareopelle ah, I didn't realise Github couldn't handle that happening. I've been using the branch locally and rebasing it periodically using the official repo's main branch. New MR: #1644 |
Log more information about why an SSL error occured as this can be very difficult to diagnose. This is logged in the same way as other probably fatal issues are, e.g. HTTP 404s.