Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context propagation prototype #146

Closed

Conversation

fbogsany
Copy link
Contributor

@fbogsany fbogsany commented Nov 7, 2019

This is an attempt to translate the context propagation prototype from open-telemetry/opentelemetry-java#655

@mwear
Copy link
Member

mwear commented Nov 7, 2019

Nice @fbogsany. I have been working on something similar. My work should move to SDK as it's actual implementation. Perhaps we can compare notes and try to synthesize the two? Here is my branch: master...mwear:context_prop_spike.

The Java proto currently has a mix between the explicit context passing an implicit. I think the goal it to use all explicit or all implicit (with an option to get a handle on context for advanced usage).

@mwear mwear mentioned this pull request Nov 8, 2019
@mwear
Copy link
Member

mwear commented Nov 8, 2019

I went ahead and combined this work, with the context prop work I have been doing. The result is here: #147.

@fbogsany
Copy link
Contributor Author

Closing in favour of #147

@fbogsany fbogsany closed this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants