Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK: integration tests #143

Merged
merged 11 commits into from
Nov 13, 2019
Merged

SDK: integration tests #143

merged 11 commits into from
Nov 13, 2019

Conversation

duonoid
Copy link
Contributor

@duonoid duonoid commented Nov 5, 2019

Fixes #82

@duonoid duonoid changed the title WIP: SDK: integration tests SDK: integration tests Nov 8, 2019
@duonoid duonoid marked this pull request as ready for review November 8, 2019 00:35
@duonoid
Copy link
Contributor Author

duonoid commented Nov 8, 2019

NOTE: the failing tests may be due to the test's misuse of the API (false positive?), or they may be exposing some actual underlying issues that we would want to address.

@duonoid
Fix nil links test
ba6e24e 
* test #total_recorded_links
@duonoid duonoid requested a review from dazuma as a code owner November 11, 2019 22:41
fbogsany
fbogsany reviewed Nov 12, 2019
View reviewed changes
sdk/test/integration/api_trace_test.rb Outdated

it 'root has accurate child_count' do
# TODO: is child_count maintained by an exporter or processor?
_(@root_span.to_span_data.child_count).must_equal 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug. Will fix. This should be maintained by the Span in coordination with the Tracer. Currently, Tracer doesn't inform Span of child creation events.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #150 for discussion of this.

@duonoid
Copy link
Contributor Author

duonoid commented Nov 12, 2019

I've addressed the feedback from @fbogsany (thanks! 😄) thus far, and will watch #150 for changes that should help with that one last failing test.

@mwear
Copy link
Member

mwear commented Nov 12, 2019

It looks like #150 is slightly complicated. Should we consider commenting out (or not including) the child count test for the time being?

@duonoid
Copy link
Contributor Author

duonoid commented Nov 12, 2019

consider commenting out (or not including) the child count test for the time being

I'd be ok with that.

fbogsany
fbogsany approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@fbogsany fbogsany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fbogsany fbogsany merged commit 0de5cf7 into open-telemetry:master Nov 13, 2019
@duonoid duonoid deleted the dd/sdk-integration-tests--82 branch November 13, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbogsany fbogsany fbogsany approved these changes

@bai bai Awaiting requested review from bai

@elskwid elskwid Awaiting requested review from elskwid

@luvtechno luvtechno Awaiting requested review from luvtechno

@mwear mwear Awaiting requested review from mwear

@dazuma dazuma Awaiting requested review from dazuma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK: integration tests
3 participants
@duonoid @mwear @fbogsany