feat: add dalli obfuscation for db_statement #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmustin
requested review from
ahayworth,
arielvalentin,
dazuma,
fbogsany,
mwear and
robertlaurin
as code owners
arielvalentin
approved these changes
Nov 10, 2021
schanjr
pushed a commit
to schanjr/opentelemetry-ruby
that referenced
this pull request
Nov 20, 2021
* initial code complete * chore: fix tests for sidekiq to support inline lua changes (open-telemetry#1011) * chore: fix tests for sidekiq to support inline lua changes to redis calls * chore: add additional sidekiq appraisal * feat: add dalli obfuscation for db_statement (open-telemetry#1013) * feat: add dalli obfuscation for db_statement * chore: linting * Link to website spec pages (open-telemetry#1018) Co-authored-by: Matthew Wear <[email protected]> * Feat: Add custom getters to common (open-telemetry#1006) Co-authored-by: Matthew Wear <[email protected]> Co-authored-by: Eric Mustin <[email protected]> Co-authored-by: Patrice Chalin <[email protected]> Co-authored-by: Matthew Wear <[email protected]> Co-authored-by: Robert <[email protected]>
schanjr
pushed a commit
to schanjr/opentelemetry-ruby
that referenced
this pull request
Nov 20, 2021
* initial code complete * chore: fix tests for sidekiq to support inline lua changes (open-telemetry#1011) * chore: fix tests for sidekiq to support inline lua changes to redis calls * chore: add additional sidekiq appraisal * feat: add dalli obfuscation for db_statement (open-telemetry#1013) * feat: add dalli obfuscation for db_statement * chore: linting * Link to website spec pages (open-telemetry#1018) Co-authored-by: Matthew Wear <[email protected]> * Feat: Add custom getters to common (open-telemetry#1006) Co-authored-by: Matthew Wear <[email protected]> Co-authored-by: Eric Mustin <[email protected]> Co-authored-by: Patrice Chalin <[email protected]> Co-authored-by: Matthew Wear <[email protected]> Co-authored-by: Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In an attempt to standardize options around database instrumentation
db_statementsettings, this PR adds the:obfuscatevalue to dalli ( a memcached client)'sdb_statementconfiguration option. When enabled, it will obfuscate thedb.statementspan attribute. In practice this simply means dropping the arguments and only including the command, which is relatively low value (since it's already available in the span name) but, for the sake of consistency with the other database instrumentations, this allows users to still capture some level of detail in theirdb.statementattribute without potentially exposing sensitive information.