Skip to content

Commit

Permalink
chore(deps): Allow google-protobuf ~> 3.14 (#1500)
Browse files Browse the repository at this point in the history
* chore(deps): Allow google-protobuf `~> 3.14`

GitHub still uses legacy versions of the protobuf gem. This makes it challenging to
upgrade to newer versions of the OTLP Exporter which only supports versions `~> 3.19`.

This change loosens the restrictions to allow GitHub to adopt newer versions of the protobuf
definitions using an older verson of the library.

This change explicitly skips 3.15 due to bugs like protocolbuffers/protobuf#8337

* squash: PR feedback from @simi

Addresses #1500 (comment)
  • Loading branch information
arielvalentin authored Jul 27, 2023
1 parent c0ebecf commit 08aec4b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion exporter/otlp/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
# SPDX-License-Identifier: Apache-2.0

(19..23).each do |i|
(14..23).each do |i|
version = "3.#{i}"
appraise "google-protobuf-#{version}" do
gem 'google-protobuf', "~> #{version}"
Expand Down
2 changes: 1 addition & 1 deletion exporter/otlp/opentelemetry-exporter-otlp.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '>= 3.0'

spec.add_dependency 'googleapis-common-protos-types', '~> 1.3'
spec.add_dependency 'google-protobuf', '~> 3.19'
spec.add_dependency 'google-protobuf', '~> 3.14'
spec.add_dependency 'opentelemetry-api', '~> 1.1'
spec.add_dependency 'opentelemetry-common', '~> 0.20'
spec.add_dependency 'opentelemetry-sdk', '~> 1.2'
Expand Down

0 comments on commit 08aec4b

Please sign in to comment.