Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates HTTP attributes #933

Closed

Conversation

andyfleming
Copy link
Contributor

@andyfleming andyfleming commented Apr 13, 2024

@andyfleming andyfleming changed the title Updates HTTP attributes chore: Updates HTTP attributes Apr 13, 2024
@andyfleming andyfleming force-pushed the update-url-attributes branch from 86bc455 to 4cfc4aa Compare April 13, 2024 03:20
@dmathieu
Copy link
Member

Note that the 1.21.0 semantic conventions recommend the use of an environment variable to make this transition smoother.
https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/http/README.md

Not all SDKs are following this recommendation (it's a SHOULD, not a MUST). But IMHO, there should be an explicit decision on whether ruby should follow the recommendation or not.

@andyfleming
Copy link
Contributor Author

andyfleming commented Apr 15, 2024

@dmathieu Hadn't seen that. Thanks! I will take a look at what's involved in supporting OTEL_SEMCONV_STABILITY_OPT_IN here.

Copy link
Contributor

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale Marks an issue/PR stale label May 16, 2024
@kaylareopelle
Copy link
Contributor

Hi @andyfleming! Are you still working on this? Would you like me to put a keep label on this PR?

@github-actions github-actions bot removed the stale Marks an issue/PR stale label May 22, 2024
Copy link
Contributor

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale Marks an issue/PR stale label Jun 21, 2024
@github-actions github-actions bot closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Marks an issue/PR stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants