Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow ActiveRecord::Querying find_by_sql to accept any arguments #918

Conversation

allan-pires
Copy link

This PR updates the find_by_sql method to allow to receive any arguments. We started to notice the following error when upgrading our Rails version that had the following change: rails/rails#51336

ArgumentError: unknown keyword: :allow_retry
    vendor/gems/3.3.0/ruby/3.3.0/gems/opentelemetry-instrumentation-active_record-0.7.0/lib/opentelemetry/instrumentation/active_record/patches/querying.rb:21:in `find_by_sql'

Copy link

linux-foundation-easycla bot commented Apr 1, 2024

CLA Not Signed

@allan-pires allan-pires force-pushed the update-find-by-sql-signature branch from 3e38212 to d6a823b Compare April 1, 2024 21:39
@allan-pires allan-pires force-pushed the update-find-by-sql-signature branch from d6a823b to 93a1271 Compare April 1, 2024 21:45
@arielvalentin
Copy link
Collaborator

hello @allan-pires this is a duplicate of #915

@allan-pires
Copy link
Author

Hey @arielvalentin thanks for the heads-up, I'll close this draft then!

@allan-pires allan-pires closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants