Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: instrumentation for racecar #72
feat: instrumentation for racecar #72
Changes from 33 commits
ec8aa55
132293e
3ab6081
dbc8def
2d2df0c
315df6d
77dfca4
f0602d7
2b68fce
adb7bf2
798d4c0
cb87af3
c058798
894108a
90b4a29
1f6cdf6
4a9f69c
0575c81
f42ea64
ad8606e
bf3c8ef
5b4d6e8
554ee08
99a9b4e
064f407
178a447
95cc551
3be8038
cbf0bf2
0108765
ae6dee4
1b047d6
17cd8bf
2e2e20a
7625877
bfe220e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but a thought: perhaps worth seeing how this performs in production circumstances before adding to
instrumentation-all
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering something like that. Has this happened before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but maybe @open-telemetry/ruby-contrib-maintainers might know? I don't think there's any problem with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally speaking I'm ok with adding it. If folks that use all don't want it they should disable it.
I minor bump with the change log/Release notes should be enough of a signal