feat!: Drop Rails 6.0 EOL #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6.0 is no longer receiving maintenance, security, or feature updates as of 01 Jun 2023 Users who want to continue instrumentating Rails applications should pin to earlier versions of the instrumentation.
arielvalentin
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
ahayworth,
plantfansam and
robbkidd
as code owners
|
👍 |
Comment on lines
-25
to
-29
| # We know that releases after MAX_MAJOR_VERSION are unstable so we | ||
| # check the major version number of the gem installed to make sure we | ||
| # do not install on a pre-release or full release of the latest | ||
| # if it exceeds the MAX_MAJOR_VERSION version. | ||
| gem_version >= MINIMUM_VERSION && gem_version.segments[0] <= MAX_MAJOR_VERSION |
There was a problem hiding this comment.
Why did you decide to remove the MAX_MAJOR_VERSION logic?
There was a problem hiding this comment.
It's the only place we do it and it felt asymmetric
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
kaylareopelle
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
This looks good to me!
I think we should talk more about implementing max major version constraints for Rails-related libraries like was recently mentioned in the #otel-ruby Slack and #373
simi
approved these changes
Oct 28, 2023
robertlaurin
approved these changes
Oct 31, 2023
jdehaan
pushed a commit
to tools-aoeur/opentelemetry-ruby-contrib
that referenced
this pull request
Nov 21, 2023
* feat!: Drop Rails 6.0 EOL 6.0 is no longer receiving maintenance, security, or feature updates as of 01 Jun 2023 Users who want to continue instrumentating Rails applications should pin to earlier versions of the instrumentation. * squash: Fix test * squash: gem version object instead of string * Update README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> --------- Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
jdehaan
added a commit
to tools-aoeur/opentelemetry-ruby-contrib
that referenced
this pull request
Nov 21, 2023
* added httpx opentelemetry adapter (open-telemetry#681) * added httpx opentelemetry adapter * Update instrumentation/httpx/CHANGELOG.md Co-authored-by: Ariel Valentin <[email protected]> * Update instrumentation/httpx/README.md Co-authored-by: Ariel Valentin <[email protected]> * Update instrumentation/httpx/README.md Co-authored-by: Ariel Valentin <[email protected]> --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Josef Šimánek <[email protected]> * chore: Change release restrictions The toys gem checks that all actions are passing before allowing a release request to be opened, however only the CI builds are actually required. This change limits the release request requirements to look specifically for CI builds * chore: Fix httpx version * chore: bump toys * release: Release opentelemetry-instrumentation-httpx 0.1.0 (initial release) (open-telemetry#713) * release: Release opentelemetry-instrumentation-httpx 0.1.0 (initial release) * Update instrumentation/httpx/CHANGELOG.md * feat!: Drop Rails 6.0 EOL (open-telemetry#680) * feat!: Drop Rails 6.0 EOL 6.0 is no longer receiving maintenance, security, or feature updates as of 01 Jun 2023 Users who want to continue instrumentating Rails applications should pin to earlier versions of the instrumentation. * squash: Fix test * squash: gem version object instead of string * Update README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> --------- Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Inline gemspec dev constraints with Appraisals. (open-telemetry#716) * Removal Sinatra 1.x Appraisal (open-telemetry#715) fix: Removal Sinatra 1.x Appraisal Rack 1.x is not directly supported anymore. Sinatra 1.x in turn "is not". Removal appraisal and add a compatibility note to both Sinatra and Rack for proper instrumentation version usage. Co-authored-by: Ariel Valentin <[email protected]> --------- Co-authored-by: Tiago <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Josef Šimánek <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Kayla Reopelle (she/her) <[email protected]> Co-authored-by: Zachery Hostens <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0 is no longer receiving maintenance, security, or feature updates as of 01 Jun 2023
Users who want to continue instrumentating Rails applications should pin to earlier versions of the instrumentation.