fix(instrumentation): Align messaging instrumentation operation names #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to the project! Please review and sign the Easy CLA and then we will bring the process of reviewing this PR. |
michal-kazmierczak
force-pushed
the
align-messaging-instrumentation-operation-names
branch
from
89bf160 to
e0af35a
Compare
michal-kazmierczak
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam and
robbkidd
as code owners
|
@michal-kazmierczak We probably want to give our end users a heads up because the span name is changing, so I am going to treat this like a Breaking Change, i.e. merge the commits with |
arielvalentin
approved these changes
Sep 7, 2023
stevenharman
added a commit
to stevenharman/opentelemetry-ruby-contrib
that referenced
this pull request
Jun 24, 2024
This was actually a breaking change, and despite `:fix!` being used in the commit, the release tooling failed to mark the change as breaking. Refs: open-telemetry#648, open-telemetry#655
arielvalentin
pushed a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #561
This PR renames spans related to the client-side operation of creating a job from
* sendto* publishin various queuing instrumentations.The diff might seem sizeable but I believe the changes are very repetitive thus it was better to bundle it together.