-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split resource_detectors into their own gems. #639
refactor: split resource_detectors into their own gems. #639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Consider using post_install_message
and let folks know about this change when they are installing gems: https://guides.rubygems.org/specification-reference/#post_install_message
May I also confirm that we are keeping the all-in-one resources detectors gem or are we going to phase out the all-in-one?
If we are keeping the all-in-one gem, will that reference the other gems once they are published?
If so then these should appear ahead of the all-in-one gem in the releases.yml
Thanks for pointing me to From my perspective we'll completely remove the We'll first need a new release of the |
Let's leave the source in place all in one gem in place for now so folks can find it when they navigate to this repo. Once this PR is merged and gems are released, then the follow up will be to remove the all-in-one from CI and the release process. |
@scbjans Mind taking a look at the merge conflicts? Once you have those resolved I will merge. |
@scbjans It looks like the merge commit did not work as I expected. Would you mind rebasing upstream main onto your branch? |
…to opentelemetry-resource_detectors gemspec.
a5ba5c3
to
916ee68
Compare
This refactoring results in the current resource detectors split into their own separate gems (as is already the case for the Container Resource Detector).
The current all-encompassing gem will still be available for now. When someone still uses it; a WARN log message will be shown stating that the new gems should be used onwards.
In a subsequent PR the all-encompassing gem (
opentelemetry-resource_detectors
) will be removed.