Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appraise sidekiq 7 #527

Conversation

Subramanya-Murugesan
Copy link

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 21, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@arielvalentin
Copy link
Collaborator

@Subramanya-Murugesan thank you for your contribution! In order for us to accept this submission we require you sign the EasyCLA. Thank you!

@Subramanya-Murugesan
Copy link
Author

Done @arielvalentin

@arielvalentin
Copy link
Collaborator

Thank you! Please take a look at the actions test suite.

Tests are failing against sidekiq 7 and it looks like due to incompatibility.

Would you be able to help us with a contribution to make the instrumentation work with this version?

@Subramanya-Murugesan
Copy link
Author

@arielvalentin Sure, will check and update

@arielvalentin
Copy link
Collaborator

@Subramanya-Murugesan I have been out sick for a while so sorry it took so long to re-run the tests.

I see it is still failing here: https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/5334256348/jobs/9852578270?pr=527

@stevenharman
Copy link
Contributor

This will be closed by #546

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale Marks an issue/PR stale label Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Marks an issue/PR stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants