-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appraise sidekiq 7 #527
Appraise sidekiq 7 #527
Conversation
@Subramanya-Murugesan thank you for your contribution! In order for us to accept this submission we require you sign the EasyCLA. Thank you! |
Done @arielvalentin |
Thank you! Please take a look at the actions test suite. Tests are failing against sidekiq 7 and it looks like due to incompatibility. Would you be able to help us with a contribution to make the instrumentation work with this version? |
@arielvalentin Sure, will check and update |
@Subramanya-Murugesan I have been out sick for a while so sorry it took so long to re-run the tests. I see it is still failing here: https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/5334256348/jobs/9852578270?pr=527 |
This will be closed by #546 |
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
No description provided.