-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Drop support for EoL Ruby 2.7 #389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielvalentin
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
ahayworth,
plantfansam and
robbkidd
as code owners
March 19, 2023 23:34
arielvalentin
force-pushed
the
drop-ruby-2.7
branch
from
March 24, 2023 22:58
c07f2eb
to
3a23943
Compare
arielvalentin
changed the title
fix: Stop testing against Ruby 2.7
feat!: Drop support for EoL Ruby 2.7
Mar 25, 2023
This is the first commit signaling dropping support for Ruby 2.7 where we no longer run compatability tests in CI. open-telemetry#363
arielvalentin
force-pushed
the
drop-ruby-2.7
branch
from
March 25, 2023 01:20
28a0850
to
9b16221
Compare
mwear
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Technically we are 3 days early (EOL date is 2023-03-31
).
@mwear 👍🏼 I am merging this on April Fool's Day... and this ain't no joke. |
kaylareopelle
added a commit
to kaylareopelle/opentelemetry.io
that referenced
this pull request
Apr 11, 2023
Ruby 2.7 support dropped by the maintainers as of March 30, 2023. The 2.7 support has been removed from the Ruby libraries as part of open-telemetry/opentelemetry-ruby-contrib#389
Closed
Earlopain
added a commit
to Earlopain/opentelemetry-ruby-contrib
that referenced
this pull request
Feb 23, 2024
Now that Ruby below 2.7 is not supported anymore (open-telemetry#389, open-telemetry@38b083a) this is not needed anymore
arielvalentin
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.ruby-lang.org/en/downloads/branches/
Fixes #363