Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: loosen the koala pin to ~> 3.0 #1309

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

michal-kazmierczak
Copy link
Contributor

The ~> 3.0.0 pin of the koala lib restricted the instrumentation to always be tested against a (7-year old) 3.0.x version. I think it's viable to loosen this restriction and enable testing against 3.x version.

This change also resolves the issue of a failing pipeline, as version 3.0.0 is incompatible with the faraday-multipart 1.1.0 dependency. For reference, here’s an example of the failure: https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/12399050526/job/34613192801

@michal-kazmierczak michal-kazmierczak changed the title fix: loosen koala pin to ~> 3.0 fix: loosen the koala pin to ~> 3.0 Dec 18, 2024
@arielvalentin arielvalentin enabled auto-merge (squash) December 18, 2024 23:18
@arielvalentin arielvalentin changed the title fix: loosen the koala pin to ~> 3.0 test: loosen the koala pin to ~> 3.0 Dec 18, 2024
@arielvalentin
Copy link
Collaborator

arielvalentin commented Dec 18, 2024

@michal-kazmierczak I am rescoping this to test since it does not require a release and only impacts the test matrix

@arielvalentin arielvalentin merged commit e3975ae into open-telemetry:main Dec 18, 2024
58 checks passed
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants