feat: Enable support for Regexp patterns when subscribing to Active Support's instrumentation Events
#1296
+207
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s instrumentation Events
erichmachado
commented
Dec 9, 2024
...ion/active_support/test/opentelemetry/instrumentation/active_support/span_subscriber_test.rb
Show resolved
Hide resolved
erichmachado
commented
Dec 9, 2024
...ion/active_support/test/opentelemetry/instrumentation/active_support/span_subscriber_test.rb
Outdated
Show resolved
Hide resolved
erichmachado
commented
Dec 9, 2024
...ion/active_support/test/opentelemetry/instrumentation/active_support/span_subscriber_test.rb
Show resolved
Hide resolved
...mentation/active_support/lib/opentelemetry/instrumentation/active_support/span_subscriber.rb
Outdated
Show resolved
Hide resolved
erichmachado
force-pushed
the
em-feat-active-support-instrumentation-regexp-subscription
branch
2 times, most recently
from
6cf922f to
9791e56
Compare
erichmachado
force-pushed
the
em-feat-active-support-instrumentation-regexp-subscription
branch
from
9791e56 to
835edc3
Compare
erichmachado
commented
Dec 10, 2024
...ion/active_support/test/opentelemetry/instrumentation/active_support/span_subscriber_test.rb
Outdated
Show resolved
Hide resolved
erichmachado
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
arielvalentin
requested changes
Dec 12, 2024
...mentation/active_support/lib/opentelemetry/instrumentation/active_support/span_subscriber.rb
Outdated
Show resolved
Hide resolved
...ion/active_support/test/opentelemetry/instrumentation/active_support/span_subscriber_test.rb
Show resolved
Hide resolved
…ber name parameter to pattern
arielvalentin
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce support for
Regexppatterns to theOpenTelemetry::Instrumentation::ActiveSupport.subscribemethod.This should be in line with a similar feature available on
ActiveSupport::Notifications.subscribe.With this update, users will be able to:
Regexppattern directly without having to resort to a customspan_name_formatterto work around crashes when processing the event name.span_name_formatteris set, since thenameparameter in the initializer includes a reference to theRegexppattern in this case.