fix: pass block argument in ActiveRecord find_by_sql patch
#1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olepbr
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
...umentation/active_record/lib/opentelemetry/instrumentation/active_record/patches/querying.rb
Show resolved
Hide resolved
|
@olepbr in addition to my comments, you are required to sign the EasyCLA before we are able to review and accept your contribution. Thanks. |
`find_by_sql` takes a block as its final argument, which is neither a positional nor a keyword argument, hence we need to pass it explicitly; before this commit, the block was not passed to the `super()` call and hence not executed, thus altering application behavior. Fixes open-telemetry#1258
olepbr
force-pushed
the
pass-block-in-activerecord-patch
branch
from
4f4bb18 to
e17cf0f
Compare
Co-authored-by: Ariel Valentin <[email protected]>
olepbr
force-pushed
the
pass-block-in-activerecord-patch
branch
from
a2331b9 to
99a676d
Compare
|
CI was failing due to a Rubocop offense triggered by the added tests; amended now. |
arielvalentin
approved these changes
Nov 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_by_sqltakes a block as its final argument, which is neither a positional nor a keyword argument, hence we need to pass it explicitly; before this PR, the block was not passed to thesuper()call and hence not executed, thus altering application behavior.Fixes #1258.