fix(active-job): Honour dynamic changes in configuration

[lavoiesl]

Fixes #1077 as introduced at #677 (comment)

Added a unit test for good measure.

[lavoiesl]

I think it'd be best to move this to the Default class and also change all the other spans to have a consistent naming, but I'm not sure if we want to lump this change in the PR, this was merely intended to fix a regression

[lavoiesl]

Separate PR to do just that: #1080

[lavoiesl]

I don't understand the commit validation error:

  ❌ PullRequest: fix(active_job): Honour dynamic changes in configuration
  Error: PullRequest:1:4: error: A scope MAY be provided after a type. A scope MUST consist of a noun describing a section of the codebase surrounded by parenthesis, e.g., fix(parser):
  
    1 | fix(active_job): Honour dynamic changes in configuration
      |    ~~~~~~~~~~~~

It sounds like fix(active_job): should fit the bill 🤔

[kaylareopelle]

I don't understand the commit validation error:

  ❌ PullRequest: fix(active_job): Honour dynamic changes in configuration
  Error: PullRequest:1:4: error: A scope MAY be provided after a type. A scope MUST consist of a noun describing a section of the codebase surrounded by parenthesis, e.g., fix(parser):
  
    1 | fix(active_job): Honour dynamic changes in configuration
      |    ~~~~~~~~~~~~

It sounds like fix(active_job): should fit the bill 🤔

@lavoiesl - I wonder if the underscore is the problem. Could you update to a hyphen?

[arielvalentin]

The tooling does support library scopes. Remove the scope (active-job) and it will pass.

[lavoiesl]

fix(active-job) works! But it's the title of the PR that needs to be changed, not the commit message 🤦🏼

[arielvalentin]

Yes sorry. It is indeed the title. When we merge PRs we squash all commits down into a single commit using the PR title.

[kaylareopelle]

@lavoiesl - Thanks for this PR! I'd like to get input from other members of the SIG about this change. I've added it to the agenda for tomorrow's meeting.

You're welcome to join the SIG meeting if you're interested! You can access the calendar invite by joining this Google Group. We meet Tuesdays at 9:00 AM PT.

Mostly, I'm concerned about setting a precedent to accommodate dynamic configuration. I'm not sure what OTel's stance is on this idea and want more input.

[kaylareopelle]

Hi @lavoiesl, we chatted about this in the SIG and are comfortable merging in this change.

Though we don't condone nor support dynamic changes in configuration, we can make this adjustment to resolve the regression you're experiencing.

Thank you for your submission and for adding tests too :)

[kaylareopelle]

@lavoiesl - It looks like the branch is out-of-date with main and I don't have the permissions to update the branch for you. Could you update your branch so we can merge this in?

[lavoiesl]

Awesome, thank you! Updated 🚀