Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update review guidelines #1052

Merged
merged 4 commits into from
Jul 15, 2024
Merged

docs: Update review guidelines #1052

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
360eb15
docs: Update review guidelines
kaylareopelle Jul 8, 2024
392dce9
Merge branch 'main' into update-review-guidelines
kaylareopelle Jul 8, 2024
224b16c
Merge branch 'main' into update-review-guidelines
kaylareopelle Jul 15, 2024
0314d20
Merge branch 'main' into update-review-guidelines
kaylareopelle Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,21 @@ merge. You'll probably get some feedback from these fine folks which helps to
make the project that much better. Respond to the feedback and work with your
reviewer(s) to resolve any issues.

The some of the things the code owners are looking for include:
* a signed [CNCF CLA][cncf-cla]
* a passing CI build
* adherence to the principles and features outlined in the
[instrumentation author's guide](.instrumentation/CONTRIBUTING.md)

Reviewers are responsible for ensuring that each merged PR's commit message
conforms to [conventional commits](https://conventionalcommits.org). This may
mean editing the commit message when you merge the pull request. Alternately,
the reviewer may ask the pull request submitter to amend the commit message of
their initial commit.
mean editing the commit message or the pull request title when you merge the
pull request. Alternately, the reviewer may ask the pull request submitter
to amend the commit message of their initial commit.

In addition, when a change is complex or a reviewer is unfamiliar with the code,
the reviewer may seek additional reviews from people more familiar with the
change before merging a PR.

## Releases

Expand Down