fix: suppress header access with symbol key deprecation warning in Racecar Instrumentation #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the text_map_getter because accessing kafka message headers with a symbol key is now deprecated in rdkafka.
ewhorton
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle and
xuan-cao-swi
as code owners
|
Hi @ewhorton! Thanks for your submission! Would you mind signing the CLA? We can't accept your submission until you do. |
|
Thanks @kaylareopelle, I'm just working with my employer to get this signed. They should be able to approve it at some point this week. |
|
Hi again @kaylareopelle, sorry for the delay, we have just been able to get this signed now 🙂 |
kaylareopelle
approved these changes
Jul 3, 2024
| @@ -4,14 +4,21 @@ module OpenTelemetry | |||
| module Instrumentation | |||
| # This class contains the ASN subsciber that instruments message processing | |||
| class ProcessMessageSubscriber | |||
| GETTER = if Gem::Version.new(::Rdkafka::VERSION) >= Gem::Version.new('0.13.0') | |||
There was a problem hiding this comment.
I would prefer to see this evaluation occur in install process since we do other gem version compatibility checks but 🤷🏼♂️ it may make it more difficult to understand. WDYT @kaylareopelle ?
arielvalentin
approved these changes
Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Rdkafka deprecation warning for header access with symbol key in the Racecar instrumentation.
This copies the approach taken for the Rdkafka instrumentation here.
Both of these can be cleaned up if/when support for rdkafka 0.12.0 is removed.
@chrisholmes