Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Updates grape appraisals #1006

Merged
merged 1 commit into from
Jun 12, 2024
Merged

ci: Updates grape appraisals #1006

merged 1 commit into from
Jun 12, 2024

Conversation

arielvalentin
Copy link
Collaborator

Fixes #1005

@arielvalentin arielvalentin requested review from a team June 11, 2024 23:03
@arielvalentin arielvalentin mentioned this pull request Jun 11, 2024
Merged
xuan-cao-swi
xuan-cao-swi approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@xuan-cao-swi xuan-cao-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Will we be discontinuing support for grape < 1.8.0?

@arielvalentin arielvalentin merged commit 57ca42b into open-telemetry:main Jun 12, 2024
54 checks passed
@arielvalentin arielvalentin deleted the update-grape-appraisals branch June 12, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuan-cao-swi xuan-cao-swi xuan-cao-swi approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

@simi simi Awaiting requested review from simi simi is a code owner

@kaylareopelle kaylareopelle Awaiting requested review from kaylareopelle kaylareopelle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grape Test Suite Failures
2 participants
@arielvalentin @xuan-cao-swi