spec the new new method

Co-authored-by: Mike Goldsmith <[email protected]>
open-telemetry · Jun 5, 2024 · e20bb1d · e20bb1d
1 parent 0043945
commit e20bb1d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/processor/baggage/lib/opentelemetry/processor/baggage/baggage_span_processor.rb b/processor/baggage/lib/opentelemetry/processor/baggage/baggage_span_processor.rb
@@ -53,6 +53,8 @@ class BaggageSpanProcessor < OpenTelemetry::SDK::Trace::SpanProcessor
         # @param [lambda] baggage_key_predicate A lambda that takes a baggage key and returns true if
         #  the key should be added to the span as an attribute, false otherwise.
         def initialize(baggage_key_predicate)
+          raise ArgumentError, 'baggage_key_predicate must respond to :call (lambda/Proc)' unless baggage_key_predicate.respond_to?(:call)
+
           @baggage_key_predicate = baggage_key_predicate
           super()
         end

diff --git a/processor/baggage/test/opentelemetry/processor/baggage/baggage_span_processor_test.rb b/processor/baggage/test/opentelemetry/processor/baggage/baggage_span_processor_test.rb
@@ -39,6 +39,14 @@
     end
   end
 
+  describe '#new' do
+    it 'requires a callable baggage_key_predicate' do
+      _(-> { OpenTelemetry::Processor::Baggage::BaggageSpanProcessor.new }).must_raise(ArgumentError)
+      err = _(-> { OpenTelemetry::Processor::Baggage::BaggageSpanProcessor.new(:not_a_callable) }).must_raise(ArgumentError)
+      _(err.message).must_match(/must respond to :call/)
+    end
+  end
+
   describe '#on_start' do
     describe 'with the ALLOW_ALL_BAGGAGE_KEYS predicate' do
       it 'adds current baggage keys/values as attributes when a span starts' do