Skip to content

Commit

Permalink
squash: will this work
Browse files Browse the repository at this point in the history
  • Loading branch information
arielvalentin committed Jun 17, 2024
1 parent 596cfee commit 72ddd59
Showing 1 changed file with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,6 @@ class CustomError < StandardError; end
describe 'when rack is manully installed' do
let(:app) do
apps_to_build = apps

OpenTelemetry::Instrumentation::Rack::Instrumentation.instance.install

Rack::Builder.new do
use(*OpenTelemetry::Instrumentation::Rack::Instrumentation.instance.middleware_args)

Expand All @@ -204,8 +201,12 @@ class CustomError < StandardError; end
end.to_app
end

before do
OpenTelemetry::Instrumentation::Rack::Instrumentation.instance.install
end

it 'creates a span for sinatra 2 or older' do
skip 'This behavior is different in versions newer than Sinatra 3' if Gem::Version.new(Sinatra::VERSION) > Gem::Version.new('2')
skip 'This behavior is different in versions newer than Sinatra 3' if Gem::Version.new(Sinatra::VERSION) > Gem::Version.new('3')

puts 'GD %%%%%%%%'
puts Sinatra::VERSION
Expand All @@ -224,7 +225,7 @@ class CustomError < StandardError; end
end

it 'creates a span for sinatra 3 or new' do
skip 'This behavior is different in versions newer than Sinatra 3' if Gem::Version.new(Sinatra::VERSION) <= Gem::Version.new('2')
skip 'This behavior is different in versions newer than Sinatra 3' if Gem::Version.new(Sinatra::VERSION) <= Gem::Version.new('3')
puts 'WTF %%%%%%%%'
puts Sinatra::VERSION
puts '%%%%%% WTF'
Expand Down

0 comments on commit 72ddd59

Please sign in to comment.