-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrumentation for aiopg #801
Add instrumentation for aiopg #801
Conversation
I signed it |
update master
update master
…supported and in python 3.8 coroutine decorators are depreacted
It seems like a significant amount of the instrumentation code here very similar to what's in the dbapi instrumentation library. I understand that because aiopg is async we won't be able to fully use the dbapi helpers, but is there some way to break down the dbapi functions so aiopg can generally use them instead of copying the code? Would make this much easier to review |
@cnnradams
All this things will make dbapi extension is too complex as for me. But I have an idea how to reduce duplicated code.
|
Sounds like a good plan to me! Also thanks for the explanation, it definitely seems like trying to use all of dbapi would be way too much hassle for what its worth. |
update branch
# Conflicts: # tox.ini
update branch
# Conflicts: # tox.ini
ext/opentelemetry-ext-aiopg/src/opentelemetry/ext/aiopg/__init__.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I updated the package name to opentelemetry-instrumentation-aiopg.
@codeboten @lzchen Thanks for review |
* chore: update Release Schedule * chore: target -> Release
Hi, everyone!
This is opentelemetry integration to aiopg. It based on dbapi extension with async wrapper and instumentor.