Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests exception handling #765

Merged
merged 6 commits into from
Jun 5, 2020
Merged

Requests exception handling #765

merged 6 commits into from
Jun 5, 2020

Conversation

HiveTraum
Copy link
Contributor

Exception handling for requests instrumentor

  • Canonical codes for different types of exceptions
  • Span attributes extracted from exception
  • Correct span closing for requests with raised errors (Didn't found my trace as span wasn't closed correct, there was a RequestException)

@HiveTraum HiveTraum requested a review from a team June 2, 2020 14:40
@HiveTraum HiveTraum changed the title Feature/requests exception handling Requests exception handling Jun 2, 2020
@lzchen
Copy link
Contributor

lzchen commented Jun 2, 2020

Might be related:

open-telemetry/opentelemetry-specification#427

toumorokoshi
toumorokoshi approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

codeboten
codeboten approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@toumorokoshi
Copy link
Member

build passed, will merge in: https://travis-ci.org/github/open-telemetry/opentelemetry-python/builds/695078392

@toumorokoshi toumorokoshi merged commit 91f656f into open-telemetry:master Jun 5, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@mayurkale22 @OlivierAlbertini @vmarchaud
chore: upgrade lerna-changelog to ^1.0.0 (open-telemetry#765)
2ee5a9c 
Co-authored-by: Olivier Albertini <[email protected]>
Co-authored-by: Valentin Marchaud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HiveTraum @lzchen @toumorokoshi @codeboten