Rename otcollector to opencensus #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
approved these changes
May 15, 2020
codeboten
suggested changes
May 15, 2020
ext/opentelemetry-ext-opencensus/src/opentelemetry/ext/opencensus/__init__.py
Outdated
Show resolved
Hide resolved
| @@ -18,7 +18,7 @@ | |||
| .. code:: python | |||
|
|
|||
| from opentelemetry import trace | |||
| from opentelemetry.ext.otcollector.trace_exporter import CollectorSpanExporter | |||
| from opentelemetry.ext.opencensus.trace_exporter import CollectorSpanExporter | |||
There was a problem hiding this comment.
Should the name of the exporters be updated to reflect this is specifically for the OpenCensus Collector as opposed to the OpenTelemetry collector? I don't know if it will create confusion to have multiple CollectorSpanExporter or if the package naming is differentiating enough.
There was a problem hiding this comment.
I fixed some naming in the last commit, please let me know if it is right now 👍
ocelotl
force-pushed
the
issue_541
branch
2 times, most recently
from
611521a
to
02412de
Compare
hectorhdzg
approved these changes
May 20, 2020
codeboten
suggested changes
May 20, 2020
...ext-opencensusexporter/src/opentelemetry/ext/opencensusexporter/metrics_exporter/__init__.py
Outdated
Show resolved
Hide resolved
…sus/__init__.py Co-authored-by: alrex <[email protected]>
This is done to keep the test code while the OpenCensus issue reported (census-instrumentation/opencensus-service#641) gets fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #541