Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: reduce build time by running longest job early #626

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

codeboten
Copy link
Contributor

Currently builds take roughly 15 minutes, as the longest job (pypy3) isn't kicked off until one of the other jobs is finished running (max 5 concurrent jobs). Prioritizing the longer jobs first should reduce the build time by about 5 minutes.

@codeboten codeboten requested a review from a team April 28, 2020 21:01
@codeboten codeboten force-pushed the reduce-build-times branch from 1f01472 to 0523233 Compare April 28, 2020 21:02
Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

To reviewers, it's not only about reducing the build time but also about fixing it, as done in the second commit of this PR.

Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, approving.

Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codeboten.

Do you know where the 5 job max is configured? It doesn't look like it's at the repository level, https://travis-ci.org/github/open-telemetry/opentelemetry-python/settings shows:

image

@c24t c24t merged commit bdd9925 into open-telemetry:master Apr 29, 2020
@codeboten
Copy link
Contributor Author

@c24t looks like it's part of the free plan according to https://travis-ci.com/plans

You will receive unlimited builds and 5 concurrent jobs for free

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
…-telemetry#653)

* fix: do not load plugin when they patch a different module than defined in config open-telemetry#626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants