Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency #614

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Apr 25, 2020

Without this, tox -e lint fails in my computer.

Fixes #613

@ocelotl ocelotl added the build & infra Issues related to build & infrastructure. label Apr 25, 2020
@ocelotl ocelotl requested a review from a team April 25, 2020 23:24
@ocelotl ocelotl self-assigned this Apr 25, 2020
@toumorokoshi
Copy link
Member

@ocelotl maybe this is already clear to you, but it's probably happening because:

  1. some packages depend on the newest dev version of dbapi, which isn't published yet
  2. when a package in a virtualenv is installed, it will attempt to install those dependencies, which is searches on pypi

Installing the local package ensures that 0.7 is installed, so pip sees that and skips trying to resolve against pypi (when it won't find the version).

Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tox continues to become a larger, harder-to-untangle file, but probably should address that at a different time.

@toumorokoshi toumorokoshi merged commit 490951a into open-telemetry:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & infra Issues related to build & infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox -e lint is failing in some cases
5 participants