-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix versionchanged doc from #466 #489
Fix versionchanged doc from #466 #489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, non blocking
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 89.05% 89.20% +0.14%
==========================================
Files 43 43
Lines 2157 2177 +20
Branches 243 243
==========================================
+ Hits 1921 1942 +21
+ Misses 166 165 -1
Partials 70 70
Continue to review full report at Codecov.
|
and add similar docs for metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Address @mauriciovasquezbernal's comment on #466.