Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versionchanged doc from #466 #489

Merged
merged 4 commits into from
Mar 14, 2020

Conversation

c24t
Copy link
Member

@c24t c24t commented Mar 14, 2020

@c24t c24t requested a review from a team March 14, 2020 21:30
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, non blocking

@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #489 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   89.05%   89.20%   +0.14%     
==========================================
  Files          43       43              
  Lines        2157     2177      +20     
  Branches      243      243              
==========================================
+ Hits         1921     1942      +21     
+ Misses        166      165       -1     
  Partials       70       70              
Impacted Files Coverage Δ
...elemetry-api/src/opentelemetry/metrics/__init__.py 93.05% <ø> (ø)
...ntelemetry-api/src/opentelemetry/trace/__init__.py 83.01% <ø> (ø)
...ry-api/src/opentelemetry/configuration/__init__.py 86.20% <0.00%> (ø)
.../src/opentelemetry/sdk/metrics/export/aggregate.py 100.00% <0.00%> (ø)
...app/src/opentelemetry_example_app/flask_example.py 100.00% <0.00%> (ø)
...etry-sdk/src/opentelemetry/sdk/metrics/__init__.py 94.40% <0.00%> (+0.03%) ⬆️
...emetry-sdk/src/opentelemetry/sdk/trace/__init__.py 92.51% <0.00%> (+0.05%) ⬆️
...xt-jaeger/src/opentelemetry/ext/jaeger/__init__.py 86.54% <0.00%> (+0.15%) ⬆️
...src/opentelemetry/ext/opentracing_shim/__init__.py 96.03% <0.00%> (+0.16%) ⬆️
...ts/src/opentelemetry/ext/http_requests/__init__.py 89.47% <0.00%> (+0.28%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c0c83...065b7be. Read the comment docs.

@c24t
Copy link
Member Author

c24t commented Mar 14, 2020

Rendered docs for trace:

image

and metrics:

image

Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@c24t c24t merged commit f52468b into open-telemetry:master Mar 14, 2020
@c24t c24t deleted the fix-versionchanged-copypasta branch March 14, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants