Add default invalid SpanContext #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return cls(cls.DEFAULT) | ||
|
|
||
|
|
||
| DEFAULT_TRACEOPTIONS = TraceOptions.get_default() |
There was a problem hiding this comment.
One thing we need to decide is whether we want these as module or class level members.
There was a problem hiding this comment.
I don't have a strong preference, but we'd have to do the assignment (e.g. TraceOptions.DEFAULT = TraceOptions.get_default) outside the class definition anyway.
|
Thanks a lot for working on this. This was important to have #41 later on. Not having classes for span/trace ids is interesting, as it definitely keeps things simple. As long as a few things are supported (such as allowing users to get an ID out of an array of bytes), we should be fine. |
carlosalberto
approved these changes
Jul 11, 2019
reyang
reviewed
Jul 11, 2019
reyang
reviewed
Jul 11, 2019
reyang
reviewed
Jul 11, 2019
mayurkale22
reviewed
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a global invalid
SpanContextand fleshes outTraceStateandTraceOptions. Since we need this package to provide thisSpanContextby default, this means getting some implementation in our API.I opted for simplicity instead of trying to match the structure and behavior of the java client exactly here. Note that there's no class for trace/span IDs, no precondition checks, etc. The change is only a few lines, but those lines are ripe for argument.
Compare to the java
SpanContextand see the related classes.