Use simple processor in http examples #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c24t
force-pushed
the
simple-export-http-examples
branch
from
fd05c13 to
59ef026
Compare
toumorokoshi
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
IIRC the major concern here was different behavior between BatchExport and Simple. This was fixed with @mauriciovasquezbernal's fix. so approving.Thanks!
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…emetry#451) * feat(opentelemetry-types): add isRemote field * fix(opentelemetry-core): set isRemote true when extracting * fix(opentelemetry-core): set isRemote on BinaryTraceContext * fix(opentelemetry-types): adjust isRemote comment Makes it more obvious when the flag changes and what the default value is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #448.
Other examples still use the batching processor, but don't show a delay between recording the span and exporting it because they exit soon after starting.