-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardizing timeout calculation in measurement consumer collect to nanoseconds #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdcg
changed the title
WIP: Standardizing timeout calculation in measurement consumer collect to nanoseconds
Standardizing timeout calculation in measurement consumer collect to nanoseconds
Jul 23, 2024
emdneto
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Care to fix lint and add CHANGELOG entry?
emdneto
reviewed
Jul 23, 2024
ocelotl
approved these changes
Jul 23, 2024
emdneto
reviewed
Jul 23, 2024
emdneto
reviewed
Jul 23, 2024
@emdneto I removed the test I had created because I thought better of it and found it unnecessary. If we just test whether the |
emdneto
approved these changes
Jul 23, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made some changes to standardize the timeout calculation in the "collect" method of the "measurement consumer" to nanoseconds. The default_timeout_millis was in milliseconds and the remaining_time in nanoseconds, and shortly after, there was a comparison between these two values with "different bases" to update the timeout_millis value of the CallbackOptions.
I also updated some sections to use scientific notation instead of exponentiation.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested only using the existing tests. I did not create any new ones.
Does This PR Require a Contrib Repo Change?
Checklist: