Events API implementation

[soumyadeepm04]

Description

Addresses #3053

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Does This PR Require a Contrib Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[soumyadeepm04]

@lzchen Could you please have a look at this?

[lzchen]

@soumyadeepm04

I think there are a few things missing from the api, such as setting the global provider, the corrensponding NoOp classes, the Proxy classes similar to the other apis. If you plan on keeping those to separate PRs (which is totally fine), I would simply change your description to not actually "fixes" the issue but addresses part of it.

[lzchen]

@soumyadeepm04

Please add a CHANGELOG.md entry.

[soumyadeepm04]

@soumyadeepm04

I think there are a few things missing from the api, such as setting the global provider, the corrensponding NoOp classes, the Proxy classes similar to the other apis. If you plan on keeping those to separate PRs (which is totally fine), I would simply change your description to not actually "fixes" the issue but addresses part of it.

Changed the description. Will create a separate PR once this is merged.

[lzchen]

@soumyadeepm04

Thanks for the contribution. Please add some tests to test the api is working correctly.

[soumyadeepm04]

@soumyadeepm04

Thanks for the contribution. Please add some tests to test the api is working correctly.

@lzchen All the classes in this code change are abstract and I was wondering if you could tell me how I could test it? I was looking at the tests for logs and only the NoOpLogger and ProxyLogger are tested as they inherit the abstract classes.
I could also include all the code in this PR to be able to test it.

[codefromthecrypt]

Maybe rename this PR and the directory to "Event" not "Events"?

[xrmx]

Maybe rename this PR and the directory to "Event" not "Events"?

Maybe we should double check with the documentation people. Need to update the heading here too 😅 https://opentelemetry.io/docs/specs/otel/logs/event-api/. Also the "Events SDK" is plural.

[codefromthecrypt]

hah yeah after I made that comment I realized there is no consistency quorum across langs on Events vs Event 🤷, nagging my favorite linter @svrnm

[lzchen]

@soumyadeepm04

Are you still working on this? If you can address the remaining points we can get this PR merged quickly :)

[soumyadeepm04]

@soumyadeepm04

Are you still working on this? If you can address the remaining points we can get this PR merged quickly :)

@lzchen

Sorry, have been a bit busy. Will have it fixed by the weekend.

[codefromthecrypt]

@jack-berg do you mind doing a pass despite this being in python? I know practice is different per lang, but possibly there are some corner cases, tests or otherwise that pop out at you as being wise to handle.

[lzchen]

@soumyadeepm04

We have a couple of folks who want to test the functionality of the events api so this PR would be blocking for them. Would you be able to streamline the work for this or would it be okay for someone else to take over?

[xrmx]

To move things forward we can merge this and I can followup with the fix for the default attributes. Or a maintainer can fix that if you prefer.

[bradbeattie]

Trying to figure out how to make use of this! Any hints or examples would be appreciated. If I figure it out in the interim, I'll edit this comment accordingly.

[xrmx]

@bradbeattie take a look at sdk tests #4176