Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: comment contrib repo change explanation in pull request template #3998

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jun 26, 2024

Description

So that the massive explanation is not rendered after PR has been opened. Comment also the description explanation while we are at it.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team June 26, 2024 13:03
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 26, 2024
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think would also be nice to put these as comment too. Wdyt?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

So that the massive explanation is not rendered after PR has been
opened. Comment also the description explanation while we are at it.
@xrmx
Copy link
Contributor Author

xrmx commented Jun 26, 2024

I think would also be nice to put these as comment too. Wdyt?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

done, thanks

Copy link
Member

@pmcollins pmcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of these changes.

@lzchen lzchen merged commit f1bebff into open-telemetry:main Jun 26, 2024
269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants