Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExponentialBucketHistogramAggregation #3978

Merged
merged 36 commits into from
Jul 18, 2024
Merged

Fix ExponentialBucketHistogramAggregation #3978

Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
0198734
Refactor __init__
ocelotl Jun 17, 2024
931933a
Refactor aggregate
ocelotl Jun 17, 2024
11e12bf
Handle case for DELTA DELTA
ocelotl Jun 17, 2024
475a8e4
Checkpoint before removing old code
ocelotl Jun 18, 2024
ed078bb
Remove old code
ocelotl Jun 18, 2024
f8f5911
Fix some test cases
ocelotl Jun 18, 2024
cc765ba
Relocate method
ocelotl Jun 18, 2024
1e69dce
Debugging test_aggregate_collect
ocelotl Jun 19, 2024
3acf866
Fix empty previous bucket handling
ocelotl Jun 19, 2024
1582ebf
Fix max and min setting
ocelotl Jun 19, 2024
09173fa
Fix explicit bucket aggregation to make it consistent
ocelotl Jun 19, 2024
ec15b16
Rearrange __init__s
ocelotl Jun 19, 2024
5aa017b
Set scale in aggregate
ocelotl Jun 19, 2024
cfc3ee3
Use right values in exponential point
ocelotl Jun 19, 2024
2d6f7d4
Set scale right
ocelotl Jun 19, 2024
8dc95a5
Start scale as None
ocelotl Jun 19, 2024
460a4d2
Make test_collect_results_cumulative pass
ocelotl Jun 19, 2024
a9d4f59
Actually use random values
ocelotl Jun 19, 2024
5d588c3
Add integration test for exponential histogram
ocelotl Jun 20, 2024
e4e144b
Handle all cases for current and previous buckets and scale
ocelotl Jun 20, 2024
17e0881
Rename test module
ocelotl Jun 24, 2024
7a70730
Use random values
ocelotl Jun 24, 2024
8455bb0
Fix bucket setting
ocelotl Jun 24, 2024
0adc8e0
WIP integration test
ocelotl Jun 24, 2024
e33e46a
WIP
ocelotl Jun 24, 2024
9ba466e
Finish integration tests
ocelotl Jun 25, 2024
056f93f
Rename variables
ocelotl Jun 25, 2024
526400a
Explain analogy with ExplicitBucket
ocelotl Jun 25, 2024
cac0ef5
Add changelog and fix lint
ocelotl Jun 25, 2024
b834964
Fix equality tests
ocelotl Jun 26, 2024
06bca7e
Fix location of returns
ocelotl Jul 3, 2024
2ef5abd
Fix another issue and add test case
ocelotl Jul 9, 2024
1aacf81
Added comments to integration test case
ocelotl Jul 11, 2024
374fb3b
Fix lint
ocelotl Jul 15, 2024
2954641
Add documentation for test case
ocelotl Jul 15, 2024
2007678
Merge branch 'main' into issue_3977
ocelotl Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#3956](https://github.com/open-telemetry/opentelemetry-python/pull/3956))
- When encountering an error encoding metric attributes in the OTLP exporter, log the key that had an error.
([#3838](https://github.com/open-telemetry/opentelemetry-python/pull/3838))
- Fix `ExponentialHistogramAggregation`
([#3978](https://github.com/open-telemetry/opentelemetry-python/pull/3978))
- Log a warning when a `LogRecord` in `sdk/log` has dropped attributes
due to reaching limits
([#3946](https://github.com/open-telemetry/opentelemetry-python/pull/3946))
Expand Down
Loading